-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first pass at hit testing #154
Conversation
<dt> Otherwise | ||
<dd> Let |result|'s {{XRLayerHitResult/hitSpace}} be a [=new=] {{XRSpace}} in the [=relevant realm=] of [=this=]. | ||
</dl> | ||
1. Set |result|'s {{XRLayerHitResult/hitSpace}} to an {{XRSpace}} that has a [=XRSpace/native origin=] to the pose that should be used to render the 3D position that was hit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be defined above, and it should be mentioned that the space is only valid during frames where the hit has happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be defined above
What do you mean by "defined above"?
it should be mentioned that the space is only valid during frames where the hit has happened.
I looked how gripSpace
is defined in the WebXR spec but I don't see where it mentions that it's only valid during the XRFrame.
The more I think about this the more it seems like a subscription API (like hit-test), or an event API would be better. But I'd like to wait for @toji to chime in |
The event API will be added when we add support for HTML layers because in that scenario the controllers (and rays) are drawn by the UA. |
I mean, the event API can also be added via a |
/agenda discuss the current hit test proposal |
This is a first proposal for hit testing.
The algorithm isn't complete yet but I want to get feedback to see if this is a good direction before filling in the details.