New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should distinguish viewerSpace from other XRSpaces #581
Comments
So the interesting thing about this issue is that it highlights a really important distinction. What we define at the API/IDL layer is often a stripped down or simplified model of the implementation concepts. Just because we keep the API simple because it's easier to add API surface area later, doesn't mean we can get away with the spec text not having concrete definitions of the different "subtypes". In other words, the spec text ought to contain a clearly defined "viewer space" type that should not exist in the idl. |
Sounds good. I wrote this issue before the PR for consolidating most of the reference spaces into a single type happened, so I wanted to match that model, but having an internal type also works. I can make a PR for this once #587 lands |
This will be fixed by https://github.com/immersive-web/editor-collab/pull/38 once #587 lands |
Fixed by #621 |
Currently
session.viewerSpace
produces anXRSpace
, however whilesession.viewerSpace
says what the space should do, there's no indication onXRSpace
itself that it may have such behavior.Especially once we start more explicitly speccing what the pose of an given space is (an outcome I hope will come out of the discussion in #565 , one which I'm willing to help write spec text for), we'll kinda need a way to differentiate between
viewerSpace
XRSpaces and other XRSpaces.There are two ways to do this:
XRViewerSpace
as a new thing. This is similar to what Chromium does internally, though it's not a real interface, just a subclassis_viewer_space
internal flag onXRSpace
, andsession.viewerSpace
constructs one with that flag set, everything else does not.I kinda prefer the former since over time that will make it easier to write stuff in the specs for each space.
The text was updated successfully, but these errors were encountered: