Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App Version to 1.79.1 #42

Merged
merged 5 commits into from
Oct 1, 2023
Merged

Update App Version to 1.79.1 #42

merged 5 commits into from
Oct 1, 2023

Conversation

hofq
Copy link
Contributor

@hofq hofq commented Sep 29, 2023

Update Chart Version, as the last commit has not created an Release

@hofq hofq changed the title Update Chart Version Update App Version to 1.79.1 Sep 29, 2023
@hofq
Copy link
Contributor Author

hofq commented Sep 29, 2023

Runs stable, without any new Bugs in Android and Web App
grafik

@PixelJonas PixelJonas self-requested a review October 1, 2023 07:26
@PixelJonas
Copy link
Contributor

LGTM

@PixelJonas PixelJonas merged commit 6da31ce into immich-app:main Oct 1, 2023
1 check passed
@bo0tzz
Copy link
Member

bo0tzz commented Oct 1, 2023

Fwiw: We shouldn't need to do chart releases just to update the app version, as people can override it in their own values.yaml

@PixelJonas
Copy link
Contributor

yeah, I thought about moving the image tag to release. This would mean that we should be fast for adapting to breaking changes.

Do you agree @bo0tzz ?

@bo0tzz
Copy link
Member

bo0tzz commented Oct 1, 2023

No, I disagree. There is no real need to keep the default image tag in the chart up to date (although we should still bump it if we're doing a release for other reasons), and I'm also not a fan in general of mutable/moving tags like release ;)

@hofq
Copy link
Contributor Author

hofq commented Oct 2, 2023

Would be nice if there are regular updates to the Chart because users then know that the Chart works with the specified image.

Also as the Chart is official, synced release Versions keep it simple to rollback or trace back any issues.

Also this would remove the need for external tools like argo image updater to keep the Image up to date

Maybe a Dependency Bot would be nice to just merge a new image after testing

@PixelJonas
Copy link
Contributor

I see your point @hofq but without having something like a CI/CD pipeline to test the chart against the latest Immich release this might introduce another set of challenges. Testing new versions can be easily done by anyone by changing the image.tag

@bo0tzz bo0tzz mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants