-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update App Version to 1.79.1 #42
Conversation
LGTM |
Fwiw: We shouldn't need to do chart releases just to update the app version, as people can override it in their own values.yaml |
yeah, I thought about moving the image tag to Do you agree @bo0tzz ? |
No, I disagree. There is no real need to keep the default image tag in the chart up to date (although we should still bump it if we're doing a release for other reasons), and I'm also not a fan in general of mutable/moving tags like |
Would be nice if there are regular updates to the Chart because users then know that the Chart works with the specified image. Also as the Chart is official, synced release Versions keep it simple to rollback or trace back any issues. Also this would remove the need for external tools like argo image updater to keep the Image up to date Maybe a Dependency Bot would be nice to just merge a new image after testing |
I see your point @hofq but without having something like a CI/CD pipeline to test the chart against the latest Immich release this might introduce another set of challenges. Testing new versions can be easily done by anyone by changing the |
Update Chart Version, as the last commit has not created an Release