Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user preferences for archive download size #10296

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

danieldietzler
Copy link
Member

@danieldietzler danieldietzler commented Jun 13, 2024

Related to #7542

Add a user preference to store preferred download size for downloading archives (multiple assets).

image

@aviv926
Copy link
Contributor

aviv926 commented Jun 14, 2024

After merging this PR will this part of the documentation become irrelevant?

@jrasm91
Copy link
Contributor

jrasm91 commented Jun 14, 2024

After merging this PR will this part of the documentation become irrelevant?

That's the goal. It should use the user's preference for download size instead.

@jrasm91 jrasm91 force-pushed the feat/user-preferences-download-size branch from 9cbcb32 to 0dcf1c5 Compare June 14, 2024 14:18
@jrasm91 jrasm91 force-pushed the feat/user-preferences-download-size branch 2 times, most recently from 50c3226 to 4a1374e Compare June 14, 2024 14:59
@jrasm91 jrasm91 force-pushed the feat/user-preferences-download-size branch from 4a1374e to 0fb7af8 Compare June 14, 2024 15:14
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@jrasm91
Copy link
Contributor

jrasm91 commented Jun 14, 2024

@aviv926 I can't be bothered to update the documentation, so feel free to make the change if you want 😄

@jrasm91 jrasm91 merged commit dddc06c into main Jun 14, 2024
22 checks passed
@jrasm91 jrasm91 deleted the feat/user-preferences-download-size branch June 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants