Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): search page #10385

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

RanKKI
Copy link
Contributor

@RanKKI RanKKI commented Jun 16, 2024

Fixed #10020

  • hide people/places section if no data
  • adjusted padding
  • show camera make/model vertically on mobile
  • fixed oversized dropdown menu on tablet

Screenshots

No data

Before After
Screenshot_1718579730 Screenshot_1718580078

Padding

Before After
Screenshot_1718580150 Screenshot_1718580163

Filters

Before After
Screenshot_1718580248 Screenshot_1718580251Screenshot_1718580267 Screenshot_1718580257 Screenshot_1718580260 Screenshot_1718580272

@RanKKI RanKKI changed the title [WIP] refactor: search page fix: search page Jun 16, 2024
@RanKKI RanKKI marked this pull request as ready for review June 16, 2024 09:18
@RanKKI RanKKI changed the title fix: search page fix(app): search page Jun 16, 2024
@alextran1502
Copy link
Contributor

Can you help include a screenshot of the before/after changes of the UI element?

@alextran1502 alextran1502 changed the title fix(app): search page fix(web): search page Jun 16, 2024
@alextran1502 alextran1502 changed the title fix(web): search page fix(mobile): search page Jun 16, 2024
@RanKKI
Copy link
Contributor Author

RanKKI commented Jun 16, 2024

Can you help include a screenshot of the before/after changes of the UI element?

my bad, included now

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thank you for the fix!

@alextran1502 alextran1502 merged commit eb987c1 into immich-app:main Jun 17, 2024
27 checks passed
@RanKKI RanKKI deleted the fix/search-filters branch June 18, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search by camera looks bad in Android
2 participants