Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Random Gallery Scroll Crash V3 #484

Closed
wants to merge 2 commits into from

Conversation

TCVinNYC
Copy link
Contributor

Possible memory leak when scroll through too many assets on a device.

When testing please state the device, how many assets you have on the server and how many assets you were able to view before the crash.
Thank you!

@alextran1502 alextran1502 marked this pull request as draft August 20, 2022 04:10
@alextran1502
Copy link
Contributor

Converted to draft to distinguish PR in progress PR vs ready-to-merge PR

@alextran1502
Copy link
Contributor

Traced the problem to remote_photo_viewer with these methods

fullProvider.resolve(const ImageConfiguration()).addListener(
ImageStreamListener((ImageInfo imageInfo, _) {
_performStateTransition(_RemoteImageStatus.full, fullProvider);
}),
);
}

That listen to and event without disposing it. So we have memory leaked there. The component was initially created without the swiping gallery features implemented so we didn't know better.

@matthinc This is FYI only.

Potential fix in #673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants