-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-assign person faces (2) #4949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
martabal
changed the title
feat: un-assign person faces (2)
feat: re-assign person faces (2)
Nov 11, 2023
martabal
force-pushed
the
feat/unassign-person-faces
branch
4 times, most recently
from
November 11, 2023 02:08
9c56126
to
2909ecb
Compare
martabal
force-pushed
the
feat/unassign-person-faces
branch
from
November 11, 2023 02:13
2909ecb
to
2ce4b64
Compare
martabal
force-pushed
the
feat/unassign-person-faces
branch
from
November 11, 2023 16:39
c81d9d1
to
bc2c02e
Compare
martabal
force-pushed
the
feat/unassign-person-faces
branch
from
November 13, 2023 10:49
30fc7d1
to
9d4fadc
Compare
Renamed face to person to avoid confusion. For example |
alextran1502
reviewed
Dec 4, 2023
alextran1502
reviewed
Dec 4, 2023
@martabal Please fix the rebase and address the comments, then feel free to merge. Thank you for the amazing work on this feature! Well done |
martabal
force-pushed
the
feat/unassign-person-faces
branch
from
December 4, 2023 18:36
3b208ba
to
96104fc
Compare
martabal
force-pushed
the
feat/unassign-person-faces
branch
from
December 5, 2023 00:56
c51e042
to
76b2819
Compare
martabal
force-pushed
the
feat/unassign-person-faces
branch
from
December 5, 2023 09:12
9cb04da
to
d6f7e0f
Compare
I think this is good |
martabal
force-pushed
the
feat/unassign-person-faces
branch
3 times, most recently
from
December 5, 2023 14:25
48a2579
to
f533afa
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
This PR introduces the ability to re-assign an asset from a person. The asset can be assigned with either a new or an existing person.
With all the recent changes, I changed a bit the global logic. The detail panel now displays people detected in the asset. while the new modal (person-side-panel) is designed to handle faces in the asset. With these changes, you can re-assign twins detected as the same person in the same asset. I added a rectangle on people faces when hovering image thumbnails (resolves #3489).
This PR closes #4153 and global edit has been added to this PR
global edit will come in a future PR.Future PRs:
Screenshots
Re-assigning faces
2023-11-10.20-05-34.mp4
Hovering thumbnails
2023-11-13.11-42-12.mp4