Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-assign person faces (2) #4949

Merged
merged 77 commits into from
Dec 5, 2023
Merged

Conversation

martabal
Copy link
Member

@martabal martabal commented Nov 10, 2023

Changes made in this PR

This PR introduces the ability to re-assign an asset from a person. The asset can be assigned with either a new or an existing person.
With all the recent changes, I changed a bit the global logic. The detail panel now displays people detected in the asset. while the new modal (person-side-panel) is designed to handle faces in the asset. With these changes, you can re-assign twins detected as the same person in the same asset. I added a rectangle on people faces when hovering image thumbnails (resolves #3489).

This PR closes #4153 and global edit has been added to this PR global edit will come in a future PR.

Future PRs:

  • The third PR will add the ability to assign and un-assign faces.
  • The fourth PR will add the ability to manually tag faces within an image.

Screenshots

Re-assigning faces

2023-11-10.20-05-34.mp4

Hovering thumbnails

2023-11-13.11-42-12.mp4

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 7:36pm

@martabal martabal changed the title feat: un-assign person faces (2) feat: re-assign person faces (2) Nov 11, 2023
@martabal martabal force-pushed the feat/unassign-person-faces branch 4 times, most recently from 9c56126 to 2909ecb Compare November 11, 2023 02:08
@martabal martabal marked this pull request as ready for review November 12, 2023 18:52
@martabal
Copy link
Member Author

martabal commented Dec 3, 2023

Renamed face to person to avoid confusion. For example Show & hide facesShow & hide people

@alextran1502
Copy link
Contributor

alextran1502 commented Dec 4, 2023

@martabal Please fix the rebase and address the comments, then feel free to merge. Thank you for the amazing work on this feature! Well done

@martabal
Copy link
Member Author

martabal commented Dec 5, 2023

I think this is good

@martabal martabal force-pushed the feat/unassign-person-faces branch 3 times, most recently from 48a2579 to f533afa Compare December 5, 2023 14:25
@alextran1502 alextran1502 merged commit 7702560 into main Dec 5, 2023
33 checks passed
@alextran1502 alextran1502 deleted the feat/unassign-person-faces branch December 5, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants