feat(server): use postgres-adapter for websockets #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Dec 8, 2023
bo0tzz
approved these changes
Dec 8, 2023
jrasm91
force-pushed
the
feat/postgres-adapter
branch
from
6661acf
to
9b817aa
Compare
|
Hi I just wanted to inform that this PR introduced regular (every second) disk writes (see #8009) as the pub sub mechanism of postgres in contrast to redis currently requires WAL (disk) commits to acquire a transaction id (see https://stackoverflow.com/a/78178571/148337) . This change is totally uncritical for large scale hosting, but for home deployments this is really annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the goal of dropping another container (redis), we will need to replace:
Tested by connecting two separate sessions to two different immich-server instances, and then triggering a websocket event from one (asset delete) and verifying it was received in the second instance.