fix(server): disable classification by default #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
59758da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7470b7cc.immich.pages.dev |
| Branch Preview URL: | https://fix-server-disable-classific.immich.pages.dev |
mertalev
force-pushed
the
fix/server-disable-classification
branch
from
651bf6d
to
59758da
Compare
jrasm91
approved these changes
Dec 15, 2023
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* disable classification by default * fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's been a recent uptick in issues relating to image tagging. When the image classification model is being exported, it can fail on ARM devices and crash the ML service along with it. As it restarts, it once again receives an object tagging request, and hence effectively gets stuck in a crash loop. Since we're moving away from using this model, it's better to keep it disabled by default to avoid this issue.
Fixes #4918
Fixes #5234
Fixes #5634