Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): feature photo not changing in the edit name component #6663

Merged
merged 2 commits into from
Jan 26, 2024
Merged

fix(web): feature photo not changing in the edit name component #6663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea34a5
fix: feature photo not changing in the edit name component
martabal Jan 26, 2024
885101d
fix: linter
martabal Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions web/src/lib/components/faces-page/edit-name-input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<script lang="ts">
import { type PersonResponseDto, api } from '@api';
import { type PersonResponseDto } from '@api';
import { createEventDispatcher } from 'svelte';
import ImageThumbnail from '../assets/thumbnail/image-thumbnail.svelte';
import Button from '../elements/buttons/button.svelte';

export let person: PersonResponseDto;
export let name: string;
export let suggestedPeople = false;
export let thumbnailData: string;

const dispatch = createEventDispatcher<{
change: string;
Expand All @@ -20,14 +21,7 @@
? 'rounded-t-lg dark:border-immich-dark-gray'
: 'rounded-lg'} bg-gray-100 p-2 dark:bg-gray-700"
>
<ImageThumbnail
circle
shadow
url={api.getPeopleThumbnailUrl(person.id)}
altText={person.name}
widthStyle="2rem"
heightStyle="2rem"
/>
<ImageThumbnail circle shadow url={thumbnailData} altText={person.name} widthStyle="2rem" heightStyle="2rem" />
<form
class="ml-4 flex w-full justify-between gap-16"
autocomplete="off"
Expand Down
1 change: 1 addition & 0 deletions web/src/routes/(user)/people/[personId]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@
bind:name
on:change={(event) => handleNameChange(event.detail)}
on:input={searchPeople}
{thumbnailData}
/>
{:else}
<div class="relative">
Expand Down
Loading