feat(cli): Use well-known endpoint to resolve API #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fe9bd06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed7790d0.immich.pages.dev |
| Branch Preview URL: | https://feat-cli-well-known.immich.pages.dev |
|
The fallback logic for constructing the URL is a bit more complex than I'd anticipated. For example, this code currently doesn't handle cases where .well-known returns successfully but builds an invalid endpoint. |
This was
linked to
issues
Jan 29, 2024
|
I'm not exactly sure what well-known does. Could you summarize the idea here? |
|
The API is served at /api usually, but it you type in the root path / to the mobile app, there is a special endpoint (/.well-known/immich) that can check instead and it returns a response that indicates where the API is actually located. It is like a special discovery endpoint that can be used so the user isn't required to remember to add /api |
jrasm91
reviewed
Feb 28, 2024
jrasm91
force-pushed
the
feat/cli-well-known
branch
from
f4b1312
to
76685df
Compare
jrasm91
force-pushed
the
feat/cli-well-known
branch
from
76685df
to
fe9bd06
Compare
jrasm91
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6487