Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server) Remove mapbox and use local reverse geocoding #738

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

zackpollard
Copy link
Contributor

@zackpollard zackpollard commented Sep 22, 2022

Still to do:

  • Variable to control the city level precision (memory usage)
  • Reduce code duplication

@zackpollard zackpollard force-pushed the feat/local-reverse-geocoder branch 4 times, most recently from 45ae7b1 to f3fc1b6 Compare September 23, 2022 00:43
@zackpollard zackpollard marked this pull request as ready for review September 23, 2022 00:43
@alextran1502
Copy link
Contributor

alextran1502 commented Sep 23, 2022

On my dev instance, this is what I see when running the PR.

image

I think this is a permission issue that the module trying to create the folder. We might need to create that folder from the application on behalf of the library. Probably somewhere in main.ts of the microservices container.

@zackpollard
Copy link
Contributor Author

On my dev instance, this is what I see when running the PR.

image

I think this is a permission issue that the module trying to create the folder. We might need to create that folder from the application on behalf of the library. Probably somewhere in main.ts of the microservices container.

Hmmm, I ddi not see this when running on my local dev server, not sure why it wouldn't have permission to create files and folders in the local filesystem, might be a specific issue with your environment?

@alextran1502 alextran1502 changed the title Remove mapbox and use local reverse geocoding feat(server) Remove mapbox and use local reverse geocoding Sep 23, 2022
@alextran1502 alextran1502 merged commit f377b64 into main Sep 23, 2022
@alextran1502 alextran1502 deleted the feat/local-reverse-geocoder branch September 23, 2022 02:50
uhthomas added a commit to uhthomas/automata that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants