fix(mobile): Refactors exif bottom sheet to use widgets and fixes slow sliding up exif bottom sheet #7671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ac1ef5c
|
| Status: | ⚡️ Build in progress... |
…experience format
martyfuhry
force-pushed
the
fix/slide-up-slowdown
branch
from
6d8f9ad
to
74c109c
Compare
…experience format
…into fix/slide-up-slowdown format
format format
martyfuhry
force-pushed
the
fix/slide-up-slowdown
branch
from
c928794
to
fc476f2
Compare
alextran1502
approved these changes
Mar 7, 2024
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
…w sliding up exif bottom sheet (immich-app#7671) * Refactors exif bottom sheet to use widgets and fixes slow sliding up experience format * Refactors exif bottom sheet to use widgets and fixes slow sliding up experience format * Fixes people * removes wrong exif bottom sheet format format * Moved more widgets out of exit bottom sheet format * small styling --------- Co-authored-by: Marty Fuhry <marty@fuhry.farm> Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
|
Could you please show only non-hidden people as it is in the web client? Thanks. Fixed... #8072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple if / else statement to replace the problem line:
Otherwise, the functionality should be left entirely intact. Alls I did was replace the
buildFoofunctions with Stateless Widgets to hopefully take more advantage of widget cache.