Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): crawl service #8190

Merged
merged 1 commit into from
Mar 22, 2024
Merged

refactor(cli): crawl service #8190

merged 1 commit into from
Mar 22, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Mar 22, 2024

  • use defaults from src/index.ts
  • make crawl a normal function
  • simplify

@jrasm91 jrasm91 added the cli Tasks related to the Immich CLI label Mar 22, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: aafa08c
Status: ✅  Deploy successful!
Preview URL: https://5b946514.immich.pages.dev
Branch Preview URL: https://refactor-cli.immich.pages.dev

View logs

danieldietzler
danieldietzler approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasm91 jrasm91 merged commit db744f5 into main Mar 22, 2024
27 checks passed
@jrasm91 jrasm91 deleted the refactor/cli branch March 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrasm91 @danieldietzler