fix(server): x264/x265 params not being set correctly #8587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passing
-x264-paramsmultiple times overwrites the full set of parameters, so this PR changes the logic here to pass it once with all relevant parameters.Of note, the intent behind setting these flags is to lower CPU usage in constrained environments. Disabling the thread pool is highly detrimental to performance, so it's only passed when specifying 1 thread.
Fixes #8494
How Has This Been Tested?
Tested that transcoding H.264 works when the thread count is set to 0 as well as 1, and that the latter shows much more mild CPU usage