fix(server): delete thumbnail for readonly asset

[Ynng]

Closes #4863
Deletes thumbnail and other generated files for read-only assets

This is safe as only external library files use the "isReadOnly" boolean

[danieldietzler]

The sidecar file isn't necessarily generated by immich.

[Ynng]

I'm not familiar with sidecar files tbh.
What are some common ways people use them?

Is it safe to assume sidecar files of external assets are also external?

[jrasm91]

What is the value of from external when an asset is deleted here?

[Ynng]

In handleAssetDeletion, for external assets, there's a guard clause making sure fromExternal is true.
In the test case the readonly asset is not external and fromExternal is false.

[malavolti]

Dear @Ynng and @danieldietzler,

I'm using the latest version of Immich (1.102.3) and I currently have 18874 Untracked files:

from an external directory that I've removed in the past.

Can you help me to solve this issue, please?

Thank you so much!

[danieldietzler]

@malavolti This is not something that should be discussed in a closed PR. Could you open a community Q&A post or hop onto our discord?