feat(server,web): system config for admin #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bo0tzz
approved these changes
Nov 12, 2022
Comment on lines
+1353
to
+1359
| export const SystemConfigKey = { | ||
| Crf: 'ffmpeg_crf', | ||
| Preset: 'ffmpeg_preset', | ||
| TargetVideoCodec: 'ffmpeg_target_video_codec', | ||
| TargetAudioCodec: 'ffmpeg_target_audio_codec', | ||
| TargetScaling: 'ffmpeg_target_scaling' | ||
| } as const; |
There was a problem hiding this comment.
The keys in this generated enum don't have the ffmpeg prefix, do you have any idea why?
There was a problem hiding this comment.
I'm not sure about that.
jrasm91
force-pushed
the
feat/system-config-2
branch
from
8e3a092
to
00b11e9
Compare
|
@jrasm91 Can you help me resolve the merge conflict? It is good to merge if @zackpollard doesn't have any other concerns |
|
Should be good to go now. |
alextran1502
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to finish the system config PR.