Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Review: Requirements #43

Closed
willu47 opened this issue Aug 11, 2021 · 0 comments · Fixed by #49
Closed

JOSS Review: Requirements #43

willu47 opened this issue Aug 11, 2021 · 0 comments · Fixed by #49

Comments

@willu47
Copy link

willu47 commented Aug 11, 2021 •
edited
Loading

Part of openjournals/joss-reviews#3601

I've noticed in cerf that there are requirements pinned in requirements.txt and in setup.py. You may want to consider removing the =~ pins as they're restrictive - you may miss patches in your dependencies. GIven that the test coverage is reasonable this may not be a risk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JOSS Review: Incorporate reviewer feedback IMMM-SFA/cerf
1 participant
@willu47