#70: HTTP Stubbing: URL matcher incorrectly strips port when using "ignore query parameters" option #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes the
HTTPStubber
withmatch(URL:)
which specify both thehost
along with an explicitport
. IN this case thehost
property ofURL
ignores the port returning only the host.The result is a failure in
matches()
function which, incorrectly, returnfalse
.This is an example:
In order to fix it we added a new a new
fullHost
property inURL
which also consider the URL.A test case is also added.