Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crates.io release #690

Closed
chrysn opened this issue Sep 26, 2022 · 5 comments · Fixed by #802
Closed

Update crates.io release #690

chrysn opened this issue Sep 26, 2022 · 5 comments · Fixed by #802
Assignees
Labels
pending release Issues that will be fixed by the next release

Comments

@chrysn
Copy link
Contributor

chrysn commented Sep 26, 2022

Please consider tagging and uploading a release for crates.io again, possibly after merging #677 [edit: and #693 ;-) ]. There have been several useful additions to c2rust around atomics, docstring handling and error handling; it would be great to have them at a simple cargo install c2rust.

Thanks for all the enhancements!

@thedataking
Copy link
Contributor

@fw-immunant tagging you to cut a new release when the PRs @chrysn mentioned land. Sound good?

@fw-immunant fw-immunant added the pending release Issues that will be fixed by the next release label Oct 6, 2022
@chrysn
Copy link
Contributor Author

chrysn commented Nov 3, 2022

Both the referenced PRs are now merged, and I don't see anything super critical in the PR queue. I think this warrants a "ping" on this issue :-)

@chrysn
Copy link
Contributor Author

chrysn commented Jan 10, 2023

Having just seen colleagues sifting through recently closed PRs while debugging breakage with the released version, I'd like to take this opportunity to ping about this once more (please let me know if I'm overly annoying here, I'm hoping the few accrued thumbs-ups justify a post).

The master branch seems to be in a good shape, and (also, to better justify posting again) passed my tests, including being built from Debian bookworm's rustc version.

That check also gives the issue a minor hint of urgency: c2rust has no MSRV it adheres to -- that's fine, but as it means that any upcoming change might require recent Rust versions, it'd be great to have a released version of c2rust that has the current feature set and works on the distributions it's working on now.

@kkysen
Copy link
Contributor

kkysen commented Jan 14, 2023

That check also gives the issue a minor hint of urgency: c2rust has no MSRV it adheres to -- that's fine, but as it means that any upcoming change might require recent Rust versions, it'd be great to have a released version of c2rust that has the current feature set and works on the distributions it's working on now.

Re just the MSRV part, c2rust-transpile could potentially have a MSRV as it builds on stable, but the newer parts of c2rust we've been working on in lifting to safe Rust use rustc internal APIs, and so we try to stick closely to the latest nightlies for that.

For c2rust-transpile, there's both a MSRV for building c2rust-transpile itself and the MSRV of the Rust it produces. Which are you asking about?

For building c2rust-transpile, that could potentially be done I think, but I'm not sure if that's what you're asking about and if there's that much value in a MSRV for building the transpiler itself.

For the emitted code, a bunch of newer Rust features simplify or enable a bunch of transpiler things (e.x. core::ffi::c_* types stabilizing), so it is helpful to continue to advance the MSRV. I also believe we'll indefinitely depend on nightly for certain features, like variadics, so that makes things much trickier, too. Hopefully, the upcoming release helps with that.

@chrysn
Copy link
Contributor Author

chrysn commented Jan 14, 2023 via email

@fw-immunant fw-immunant linked a pull request Jan 28, 2023 that will close this issue
@kkysen kkysen mentioned this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release Issues that will be fixed by the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants