fix: refactor import paths to fix generated types #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithbro-imx
approved these changes
Nov 8, 2023
cross-module testing initiative the SDK team is doing this cycle should help to catch these kinds of things |
deepti-imx
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some import statements in the SDK were causing erroneous types to be generated in
index.d.ts. The PR fixes those import paths to generate the correct types.Customer Impact
Fixes types in
index.d.tsFixed
index.d.tsreference toconfigwhich didn't existThings worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.