fix: ID-1538 Resolved issue with redirect logout not logging out of Magic #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-Alonso
approved these changes
Apr 5, 2024
carmen0208
approved these changes
Apr 5, 2024
Comment on lines
+233
to
+235
| await Promise.allSettled([ | ||
| this.authManager.logout(), | ||
| this.magicAdapter.logout(), |
There was a problem hiding this comment.
QQ related to this https://imtbl.slack.com/archives/C06SX4AUBNE/p1712280521367519 - Does this also need to be in the order of
magicAdapter.logout()authManger.logout()
Also, do we need to prevent calling authManager.logout if the call to magicAdapter.logout failed? Currently, one of these could reject and the other could resolve - we do not check the results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where users were not being correctly logged out of their Magic wallet.
Detail and impact of the change
Changed
redirectlogout mode.