feat: [CM-607][Sale Widget] Get order config from product skus + qty #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesgodi
force-pushed
the
feat/CM-607-client-config-quote-from-items
branch
from
25ec148
to
54b7aaf
Compare
jhesgodi
changed the title
jhesgodi
commented
May 9, 2024
| tokenAddress, | ||
| }: UseSmartCheckoutInput) => { | ||
| const amount = '0'; |
There was a problem hiding this comment.
Please ignore this patch
The entire hook gets remove in next PR as is not longer required for multi currency flow.
jhesgodi
requested review from
jwhardwick,
dreamoftrees,
luads and
mimi-imtbl
and removed request for
jwhardwick
luads
previously approved these changes
May 13, 2024
dreamoftrees
previously approved these changes
May 13, 2024
mimi-imtbl
previously approved these changes
May 14, 2024
jwhardwick
previously approved these changes
May 14, 2024
luads
previously approved these changes
May 14, 2024
jhesgodi
dismissed stale reviews from luads, jwhardwick, mimi-imtbl, and dreamoftrees
via
5937019
luads
approved these changes
May 14, 2024
mimi-imtbl
approved these changes
May 14, 2024
jwhardwick
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve how primary sales widget gets the quote and configurations for an order. Instead of the widget knowing which
amountneeds to be paid, it can now instead pass the itemssku&qtyto the/client-configservice, and it will be able to return a response with by item amounts and total amounts including conversions.BREAKING CHANGE:
Requires customers to implement new Quotes endpoint
Screenshots
Before:
After: Multi item with correct pricing conversion
Detail and impact of the change
Added
Changed
amountparamRemoved
amountparamFixed