fix: Change ethers.utils imports #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithbro-imx
changed the title
wdinau
approved these changes
Jun 18, 2024
pano-skylakis
approved these changes
Jun 18, 2024
CodeSchwert
approved these changes
Jun 18, 2024
luads
approved these changes
Jun 18, 2024
EdwardJES
reviewed
Jun 18, 2024
|
|
||
| describe('signRegisterEthAddress()', () => { | ||
| test('Correctly signs message', async () => { | ||
| const signer = new Wallet('5c7b4b5cad9a3fc7b1ba235a49cd74e615488a18b0d6a531739fd1062935104d'); |
There was a problem hiding this comment.
small thing: ethers allows you to create random wallets for testing https://docs.ethers.org/v4/api-wallet.html#creating-instances
There was a problem hiding this comment.
Oh nice, I just copied from the other tests but I would like to use this in future
EdwardJES
approved these changes
Jun 18, 2024
Jon-Alonso
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking-change:if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.feat:,fix:,refactor:,docs:, orchore:.Summary
Change import for ethers.utils as advised by ethers-io/ethers.js#3179
Some users are reporting the following error when building:
Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?