Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-CHANGELOG] feat: primary revenue widget setup - part 1 #896

Merged
merged 22 commits into from
Oct 2, 2023

Conversation

jhesgodi
Copy link
Contributor

Summary

Add the foundations for primary revenue widget

Why the changes

Screen Shot 2023-09-25 at 12 26 38 pm

Copy link
Contributor

@deepti-imx deepti-imx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and few questions to gain some context.

@jhesgodi jhesgodi changed the title [NO-CHANGELOG] feat: primary revenue widget setup [NO-CHANGELOG] feat: primary revenue widget setup - part 1 Sep 26, 2023
@proletesseract
Copy link
Contributor

proletesseract commented Sep 26, 2023

hey @jhesgodi can you please make sure to add me as a reviewer on the primary sales PR's :)

Copy link
Contributor

@proletesseract proletesseract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment about the Events, feel free to reach out if you need clarification on the implementation

@proletesseract
Copy link
Contributor

I know there's a few PR's coming through, so let me know if these things are handled there;

The primary revenue widget should be added to the widgets-sample-app to test both the React Component and the Vanilla JS versions when they are built into the compiled bundle. There's examples of the other widgets being used in the sample app if you need a reference, or one of us can talk you through it.

It may not quite be relevant on this PR, but each widget should have cypress and jest tests to validate the UI and any important functionality.

@jhesgodi
Copy link
Contributor Author

I know there's a few PR's coming through, so let me know if these things are handled there;

The primary revenue widget should be added to the widgets-sample-app to test both the React Component and the Vanilla JS versions when they are built into the compiled bundle. There's examples of the other widgets being used in the sample app if you need a reference, or one of us can talk you through it.

It may not quite be relevant on this PR, but each widget should have cypress and jest tests to validate the UI and any important functionality.

thank you, and yes we have those changes coming up, its it okay to add have those in a new PR after this one?

@jhesgodi jhesgodi enabled auto-merge (squash) October 2, 2023 23:21
@jhesgodi jhesgodi merged commit fd21570 into main Oct 2, 2023
6 checks passed
@jhesgodi jhesgodi deleted the gpr/primary-revenue-widget-setup branch October 2, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants