Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-1751 -- disable chunking #920

Merged
merged 2 commits into from
Sep 29, 2023
Merged

WT-1751 -- disable chunking #920

merged 2 commits into from
Sep 29, 2023

Conversation

andrearampin
Copy link
Contributor

Summary

Due to the increase size of the checkout bundle, our build process has started chunking the build bundle.

This is not something visible when we develop using the sample app in the widgets-lib because the chunks are served by the react application.

However when we release the build, the building process only takes the main.js leaving behind needed chunks.

We could move the chunks in the final NPM package dist folder but we would then have to modify the JS code to point to JS deliver.

Why the changes

Bundle splitting causing app to crash

Things worth calling out

Before submitting the PR, please consider the following:

  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.

@andrearampin andrearampin requested a review from a team as a code owner September 29, 2023 01:57
Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 👍

@andrearampin andrearampin enabled auto-merge (squash) September 29, 2023 03:01
@andrearampin andrearampin merged commit e53ec38 into main Sep 29, 2023
6 checks passed
@andrearampin andrearampin deleted the WT-1751 branch September 29, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants