Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ID-1006 ID-1009 view offers passport sample #931

Merged
merged 4 commits into from
Oct 5, 2023
Merged

feat: ID-1006 ID-1009 view offers passport sample #931

merged 4 commits into from
Oct 5, 2023

Conversation

haydenfowler
Copy link
Contributor

Summary

This PR:

  • adds functionality to view & accept an offer
  • makes the logging of responses from the SDK consistent
  • makes the Order grid more consistent with the Trade grid

Why the changes

So that we can test bids & asks functionality

Note: The confirmation screen that is displayed when accepting an offer has not been updated yet.

AcceptOffer.mov

@haydenfowler haydenfowler requested a review from a team as a code owner October 4, 2023 03:08
@haydenfowler haydenfowler changed the title feat: ID-1006 view offers passport sample feat: ID-1006 ID-1009 view offers passport sample Oct 4, 2023
@haydenfowler haydenfowler enabled auto-merge (squash) October 4, 2023 23:41
@haydenfowler haydenfowler merged commit ef85652 into main Oct 5, 2023
6 checks passed
@haydenfowler haydenfowler deleted the feature/ID-1006-view-offers-passport-sample branch October 5, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmen0208 carmen0208 carmen0208 approved these changes

@Jon-Alonso Jon-Alonso Jon-Alonso approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haydenfowler @carmen0208 @Jon-Alonso