Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPR | Route errors to error views #972

Merged
merged 31 commits into from
Oct 15, 2023
Merged

Conversation

jhesgodi
Copy link
Contributor

Summary

Adds the logic to redirect to error views whenever errors happen across the widget

@jhesgodi jhesgodi requested a review from a team as a code owner October 11, 2023 03:33
Copy link
Contributor

@jwhardwick jwhardwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

Base automatically changed from gpr/sale-context-add-error-routing-fn to main October 12, 2023 00:34
@jhesgodi jhesgodi enabled auto-merge (squash) October 15, 2023 22:00
@jhesgodi jhesgodi merged commit 306fd90 into main Oct 15, 2023
6 checks passed
@jhesgodi jhesgodi deleted the gpr/sale-widget-route-to-error-views branch October 15, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants