Feat: wt 1770 update swap widget footer #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepti-imx
reviewed
Oct 17, 2023
packages/checkout/widgets-lib/src/components/Footer/QuickswapFooter.tsx
Outdated
Show resolved
Hide resolved
imx-mikhala
approved these changes
Oct 17, 2023
| @@ -18,13 +19,15 @@ import { EventTargetContext } from '../../../context/event-target-context/EventT | |||
| import { UserJourney, useAnalytics } from '../../../context/analytics-provider/SegmentAnalyticsProvider'; | |||
|
|
|||
| export interface SwapCoinsProps { | |||
| theme: WidgetTheme; | |||
There was a problem hiding this comment.
Is there any way for us to get the theme from the BIOME context / provider?
There was a problem hiding this comment.
Don't think so. This would require changes in biome repo and it may/may not impact others that use BiomeProvider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://immutable.atlassian.net/browse/WT-1770
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.