This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Fixes #22 by using weblinks instead of API links. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a bit hard coded towards the current GitHub structure but we'll see in future if there are much changes.
| @@ -117,9 +117,11 @@ def process_github_user(repo_data, user, pat, github, verbose, | |||
| print " Dependencies: "+str(deps) | |||
|
|
|||
| # Create a data structure for information related to this version | |||
| tagurlbase = ('https://github.com/%s/%s/archive/%s' | |||
There was a problem hiding this comment.
This is probably not a major concern, but tag names are beyond our control. As such, in this context they could be a vector for malicious code. So it would be best to properly escape them in general. As I said, it probably isn't a big deal here though. GitHub may already do some of that. And you are rather limited in tag name size, I assume.
There was a problem hiding this comment.
Do you know of a simple "python escape" function for this purpose?
xogeny
pushed a commit
that referenced
this pull request
Oct 11, 2013
Fixes #22 by using weblinks instead of API links.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit hard coded towards the current GitHub structure but
we'll see in future if there are much changes.