Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make trait methods in oid4vc-core async #74

Merged
merged 2 commits into from
May 7, 2024
Merged

feat: make trait methods in oid4vc-core async #74

merged 2 commits into from
May 7, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented May 7, 2024 •
edited
Loading

Description of change

See title

Links to any relevant issues

How the change has been tested

Existing (adjusted) tests still pass.

This functionality is also tested in in this branch in the ssi-agent.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel changed the title feat: make fn encode async feat: make trait methods in oid4vc-core async May 7, 2024
@nanderstabel nanderstabel self-assigned this May 7, 2024
@nanderstabel nanderstabel added the Breaking change A change to the API that requires a major release. label May 7, 2024
@nanderstabel nanderstabel linked an issue May 7, 2024 that may be closed by this pull request
Make trait methods in oid4vc-core async #73
Closed
1 task
@nanderstabel nanderstabel marked this pull request as ready for review May 7, 2024 20:23
@nanderstabel nanderstabel merged commit 7d31e81 into dev May 7, 2024
1 check passed
@nanderstabel nanderstabel deleted the feat/async-traits branch May 7, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-mader daniel-mader daniel-mader approved these changes

@Oran-Dan Oran-Dan Awaiting requested review from Oran-Dan

Assignees

@nanderstabel nanderstabel

Labels
Breaking change A change to the API that requires a major release.
Projects
Impierce SSI Stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make trait methods in oid4vc-core async
2 participants
@nanderstabel @daniel-mader