Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for multiple signing algorithms #76

Merged
merged 5 commits into from
Jul 16, 2024
Merged

feat: add support for multiple signing algorithms #76

merged 5 commits into from
Jul 16, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented May 21, 2024 •
edited
Loading

Description of change

Previously all data in all flows where signed using EdDSA by default. This current PR adds support for the configuration of multiple singing algorithms.

Links to any relevant issues

Closes #71

How the change has been tested

Adjusted relevant tests.
The changes made in this PR have also been tested through:

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel self-assigned this May 21, 2024
@nanderstabel nanderstabel added the Breaking change A change to the API that requires a major release. label May 21, 2024
@nanderstabel nanderstabel linked an issue May 21, 2024 that may be closed by this pull request
Add support for configurable signature types #71
Closed
4 tasks
@nanderstabel nanderstabel marked this pull request as ready for review May 21, 2024 13:22
@nanderstabel nanderstabel changed the title feat: add support for multiple singing algorithms feat: add support for multiple signing algorithms May 21, 2024
This was referenced May 21, 2024
Merged
Closed
@nanderstabel nanderstabel merged commit dac4102 into dev Jul 16, 2024
1 check passed
@nanderstabel nanderstabel deleted the feat/multi-alg-support branch July 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-mader daniel-mader daniel-mader approved these changes

Assignees

@nanderstabel nanderstabel

Labels
Breaking change A change to the API that requires a major release.
Projects
Impierce SSI Stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for configurable signature types
2 participants
@nanderstabel @daniel-mader