Tighten no-named-export error message

import-js · Aug 15, 2018 · c506c5c · c506c5c
1 parent 900bd20
commit c506c5c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 24 deletions.
diff --git a/src/rules/no-named-export.js b/src/rules/no-named-export.js
@@ -11,21 +11,21 @@ module.exports = {
       return {}
     }
 
-    const preferDefault = 'Prefer default export.'
+    const message = 'Named exports are not allowed.'
 
     return {
       ExportAllDeclaration(node) {
-        context.report({node, message: preferDefault})
+        context.report({node, message})
       },
 
       ExportNamedDeclaration(node) {
         if (node.specifiers.length === 0) {
-          return context.report({node, message: preferDefault})
+          return context.report({node, message})
         }
 
         const someNamed = node.specifiers.some(specifier => specifier.exported.name !== 'default')
         if (someNamed) {
-          context.report({node, message: preferDefault})
+          context.report({node, message})
         }
       },
     }

diff --git a/tests/src/rules/no-named-export.js b/tests/src/rules/no-named-export.js
@@ -36,10 +36,10 @@ ruleTester.run('no-named-export', rule, {
       `,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }, {
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
@@ -48,7 +48,7 @@ ruleTester.run('no-named-export', rule, {
         export default bar;`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
@@ -58,17 +58,17 @@ ruleTester.run('no-named-export', rule, {
       `,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }, {
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export const foo = 'foo';`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
@@ -78,35 +78,35 @@ ruleTester.run('no-named-export', rule, {
       `,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export { foo, bar }`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export const { foo, bar } = item;`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export const { foo, bar: baz } = item;`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export const { foo: { bar, baz } } = item;`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
@@ -116,63 +116,63 @@ ruleTester.run('no-named-export', rule, {
       `,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }, {
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export * from './foo';`,
       errors: [{
         ruleId: 'ExportAllDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export const { foo } = { foo: "bar" };`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export const { foo: { bar } } = { foo: { bar: "baz" } };`,
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: 'export { a, b } from "foo.js"',
       parser: 'babel-eslint',
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export type UserId = number;`,
       parser: 'babel-eslint',
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: 'export foo from "foo.js"',
       parser: 'babel-eslint',
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
     test({
       code: `export Memory, { MemoryValue } from './Memory'`,
       parser: 'babel-eslint',
       errors: [{
         ruleId: 'ExportNamedDeclaration',
-        message: 'Prefer default export.',
+        message: 'Named exports are not allowed.',
       }],
     }),
   ],