Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds no-useless-path-segments documentation. #1068

Merged

Conversation

manovotny
Copy link
Contributor

Fixes #1032

@ljharb ljharb added the docs label Apr 9, 2018
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb
Copy link
Member

ljharb commented Apr 9, 2018

cc @graingert

@ljharb ljharb merged commit 4d0c799 into import-js:master Apr 10, 2018
@manovotny manovotny deleted the no-useless-path-segments-documentation branch April 10, 2018 01:44
import "../pages/about.js"; // should be "./pages/about.js"
import "../pages/about"; // should be "./pages/about"
import "./pages//about"; // should be "./pages/about"
import "./pages/"; // should be "./pages"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth adding a note about:

import "../" -> import "./"

* in my-project/app.js
*/

import "./../pages/about.js"; // should be "./pages/about.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be "./../my-project/pages/about.js" // should be "./pages/about.js"

@ljharb
Copy link
Member

ljharb commented Apr 10, 2018

Indeed; a follow up would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants