/ eslint-plugin-import Public
Update no internal modules with exports #1691
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
About the breaking change
In the ticket it was suggested to add an option for this behavior. Do you still want this rule behind an option? This behavior with the
exportfeels so natural to me that I would feel strange if it wasn't the default behavior.
I update the documentation, but I didn't know how to update the changelog. I wouldn't be against some guidance or help here
Step down rule
I hesitated to clean the code in
/src/rules/no-internal-modules.jsto use the step down rule, but I don't want to impose my tastes on this. Do you want me to do it?