New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] order
: Recognize pathGroup config for first group
#1719
[Fix] order
: Recognize pathGroup config for first group
#1719
Conversation
Co-authored-by: Emily Marigold Klassen <forivall@gmail.com> Co-authored-by: Vitaly Gordon <rocket.mind@gmail.com>
This comment has been minimized.
This comment has been minimized.
4 similar comments
2171443
to
fe6cea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combined this and the test from #1724. Thanks!
Because I pushed this to two PRs, two appveyor builds ran. The second failed (https://ci.appveyor.com/project/benmosher/eslint-plugin-import/builds/32116513), but the first succeeded (https://ci.appveyor.com/project/benmosher/eslint-plugin-import/builds/32116512), so I'm going to merge through the failure. |
With the config
, react wasn't being recognized as a part of the "builtin" group, since the rank would end up being
0
, which is a falsy value. The fix here, is to check forundefined
instead.My current workaround is to define
instead, (which results in a rank
-0.1
, so it's not falsy).