Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-restricted-paths support glob patterns #2219

Merged
merged 1 commit into from Sep 6, 2021

Conversation

@stropho
Copy link
Contributor

@stropho stropho commented Sep 6, 2021

Connected to #2123

Added support for glob patterns. More details in docs/rules/no-restricted-paths.md in this PR

Although it would be easier to replace the rule so it works with globs only, I tried to don't make any breaking changes 馃

@codecov
Copy link

@codecov codecov bot commented Sep 6, 2021

Codecov Report

Merging #2219 (7784948) into main (bb8eab9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2219      +/-   ##
==========================================
+ Coverage   84.17%   84.27%   +0.09%     
==========================================
  Files          93       93              
  Lines        2951     2969      +18     
  Branches      874      879       +5     
==========================================
+ Hits         2484     2502      +18     
  Misses        467      467              
Impacted Files Coverage 螖
src/rules/no-restricted-paths.js 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bb8eab9...7784948. Read the comment docs.

Loading

ljharb
ljharb approved these changes Sep 6, 2021
Copy link
Collaborator

@ljharb ljharb left a comment

New tests only, nothing major jumps out at me in the implementation, nice!

Loading

src/rules/no-restricted-paths.js Outdated Show resolved Hide resolved
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants