Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-default-import: limit highlight to the word "default" #2299

Merged

Conversation

pmcelhaney
Copy link
Contributor

Instead of reporting the entire export default declaration:

image

Only reporting the "default" token:

image

@pmcelhaney pmcelhaney force-pushed the targeted-reporting-on-no-default-export branch 3 times, most recently from 7cb7df9 to 0fa6276 Compare November 10, 2021 22:17
@ljharb ljharb force-pushed the targeted-reporting-on-no-default-export branch from 0fa6276 to 34c6d16 Compare November 10, 2021 22:22
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks

@ljharb ljharb changed the title [Changed]: no-default-import - limit highlight to the word "default" [Fix] no-default-import: limit highlight to the word "default" Nov 10, 2021
@ljharb ljharb force-pushed the targeted-reporting-on-no-default-export branch 2 times, most recently from 4e48a32 to 7eacf22 Compare November 10, 2021 23:47
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2299 (2c33530) into main (e8794f1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   94.64%   94.64%   -0.01%     
==========================================
  Files          65       65              
  Lines        2691     2689       -2     
  Branches      891      890       -1     
==========================================
- Hits         2547     2545       -2     
  Misses        144      144              
Impacted Files Coverage Δ
src/rules/no-default-export.js 90.90% <100.00%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8794f1...2c33530. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants