-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support extra options
argument for resolver
#2519
base: main
Are you sure you want to change the base?
Conversation
6c678d2
to
761b799
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2519 +/- ##
==========================================
- Coverage 95.19% 95.16% -0.04%
==========================================
Files 68 66 -2
Lines 2977 2831 -146
Branches 1028 951 -77
==========================================
- Hits 2834 2694 -140
+ Misses 143 137 -6
... and 59 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Done! |
context
into resolver argumentsoptions
argument for resolver
80be205
to
7c7e472
Compare
Friendly ping @ljharb |
I'm moving slowly on this one because of the potential for breakage. Specifically, "old utils + old plugin", and "new utils + new plugin", obviously will work fine. However, I need to convince myself that "new utils + old plugin" and "old utils + new plugin" will continue to work. I'm likely going to wait until I've released all the unreleased changes before merging this. |
I should pass the flattened |
7c7e472
to
a166e1a
Compare
a166e1a
to
b4a6ef3
Compare
b4a6ef3
to
877b4ca
Compare
src/ExportMap.js
Outdated
@@ -24,7 +24,7 @@ let ts; | |||
const log = debug('eslint-plugin-import:ExportMap'); | |||
|
|||
const exportCache = new Map(); | |||
const tsConfigCache = new Map(); | |||
const tsconfigCache = new Map(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rename it as tsconfigCache
because tsconfig
is much common usage.
Any chance this PR can get some love @ljharb? This PR helps resolve the eslint monorepo issues regarding looking for a single root tsconig vs individual package level tsconfigs. |
When you say "All of the unreleased changes", I am just trying to get a rough approximation for what that looks like. Are we talking a few weeks or a few months? |
I don't cut releases on any particular timeline. It could be hours, or weeks. |
@JounQin Looks like there's a very small merge conflict on your branch. Can you resolve so this PR can move into a mergeable state again? @ljharb I just wanted to echo the sentiment that this would be great to have. Currently setting up a monorepo with TS and I would love to use this plugin. Have you had more time to think about the inclusion of this PR? |
Wanted to check in and see if there might be any option to help contribute to getting this merged? Would love to revive this feature as its a prerequisite to a few other packages. |
877b4ca
to
d971840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased this PR and split it up into separate commits - the final commit is the one that I'm concerned about:
- it has no tests - the tests are in the third commit, and relate to resolvers, but we need tests that relate to the ExportMap changes
- is this potentially a breaking change, if someone's using an older version of eslint-module-utils, with the ExportMap changes?
close #2108