Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new rule no-restricted-paths (fixes #155) #371

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

lo1tuma
Copy link
Contributor

@lo1tuma lo1tuma commented Jun 6, 2016

No description provided.

The following patterns are not considered problems when configuration set to `[ { "target": "./client", "from": "./server" } ]`:

```js
import foo from '../server/baz';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see how this is different, except for the fact that server/baz does not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, it should be import baz from '../client/baz'.

@jfmengels
Copy link
Collaborator

A few comments, but this looks really good, thanks @lo1tuma!

@lo1tuma
Copy link
Contributor Author

lo1tuma commented Jun 6, 2016

@jfmengels Thanks for the review. All comments have been addressed.

@jfmengels
Copy link
Collaborator

Great work @lo1tuma, LGTM :)

@gilligan
Copy link

Any chance of merging this sometime soon?

@benmosher benmosher added this to the v1.10.0 milestone Jun 21, 2016
@benmosher benmosher merged commit 8141713 into import-js:master Jun 21, 2016
@lo1tuma lo1tuma deleted the no-restricted-paths branch June 21, 2016 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants