-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve configs for webpack2 #569
Conversation
It's not clear to me what this PR accomplishes. Changes appear to be formatting and config for tests, only. Can you elaborate on what the intended outcome is? I'm familiar with the cc @charlieschwabacher, who is apparently pretty enthused about this 😄 |
@benmosher - including
So you end up needing to remove the (the relevant non-test changes are to lines 189 and 196 of resolvers/webpack/index.js) |
@charlieschwabacher ah, got it, thanks for the detail. I looked right at those lines but just didn't see it the first time. |
merged (had to move the changelog note, but kept your changes) thanks! |
Added configs for webpack2 (since version 2.1.0-beta.23)
modulesDirectories
now change tomodules