Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form-countdown): resolve incompatibility with Give core 2.1 #29

Closed
Benunc opened this issue Jun 13, 2018 · 2 comments · Fixed by #30
Closed

fix(form-countdown): resolve incompatibility with Give core 2.1 #29

Benunc opened this issue Jun 13, 2018 · 2 comments · Fixed by #30
Assignees
@Sidsector9
Milestone
Sprint: 2018/06/0...

Comments

@Benunc
Copy link
Member

Benunc commented Jun 13, 2018

Issue Overview

The plugin doesn't appear to be working with 2.1 at all. Forms are not closed at the end of the countdown, and the clock JS throws an error.

Expected Behavior

I expect it to work.

Steps to Reproduce (for bugs)

  1. Enable a form countdown as well as the clock.
  2. View the form on the front end.
  3. Once the form is set to close, view the form again.
  4. It will still be open, and the clock JS throws an error.
@ravinderk ravinderk assigned Sidsector9 and unassigned Sidsector9 Jun 18, 2018
@Sidsector9 Sidsector9 mentioned this issue Jun 19, 2018
Merged
3 tasks
ravinderk added a commit that referenced this issue Jun 21, 2018
@ravinderk
Merge pull request #30 from WordImpress/issue/29
1b9796b 
fix(form-countdown): resolve incompatibility with Give core 2.1 #29
@Benunc
Copy link
Member Author

Benunc commented Jun 27, 2018

Please test this on PHP 7.2, it's still broken there.

@Benunc Benunc reopened this Jun 27, 2018
@ravinderk
Copy link
Collaborator

@Benunc issue has been fixed

@ravinderk ravinderk reopened this Jun 28, 2018
@raftaar1191 raftaar1191 mentioned this issue Jun 29, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
Sprint: 2018/06/06 - 2018/06/26
Development

Successfully merging a pull request may close this issue.

fix(form-countdown): resolve incompatibility with Give core 2.1 #29 impress-org/Give-Form-Countdown
3 participants
@ravinderk @Benunc @Sidsector9