Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give_get_field_description() needs to take into account $field['desc'] usage #1668

Closed
DevinWalker opened this issue May 5, 2017 · 0 comments
Closed

give_get_field_description() needs to take into account $field['desc'] usage #1668

DevinWalker opened this issue May 5, 2017 · 0 comments
Assignees
@DevinWalker
Milestone
1.8.8

Comments

@DevinWalker
Copy link
Member

Issue Overview

Several add-ons don't use the full work description within the field's params but rather desc. The give_get_field_description() function should check for both . Currently it only checks for the description array key. https://github.com/WordImpress/Give/blob/master/includes/admin/give-metabox-functions.php#L759

Expected Behavior

Both desc and description output.

Current Behavior

Only description in full works.
@DevinWalker DevinWalker added this to the 1.8.8 milestone May 5, 2017
@DevinWalker DevinWalker self-assigned this May 5, 2017
DevinWalker added a commit that referenced this issue May 5, 2017
@DevinWalker
Added additional conditional check for $field[‘desc’] #1668
2c7c689
@DevinWalker DevinWalker mentioned this issue May 5, 2017
Merged
DevinWalker pushed a commit that referenced this issue May 5, 2017
Merge pull request #1669 from WordImpress/issue/1668
b1a7860 
Added additional conditional check for $field[‘desc’] #1668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.8.8
Development

No branches or pull requests
1 participant
@DevinWalker