Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation total does not show the currency sign when changing custom amount #485

Closed
pryley opened this issue Feb 22, 2016 · 6 comments
Closed
Assignees
Milestone

Comments

@pryley
Copy link
Contributor

pryley commented Feb 22, 2016

image

@DevinWalker
Copy link
Member

Thanks @pryley

Good to see you again. I'll check this out ASAP

@DevinWalker
Copy link
Member

Issue found:

2-25-2016 3-37-04 pm

@pryley
Copy link
Contributor Author

pryley commented Feb 26, 2016

Strange, it doesn't happen here and I'm using my fork with the 3 pull requests
on a live site. Maybe it has to do with the recurring addon, I was having issues
with it so I disabled the addon so did not test it with that.
All the pull request does is set the missing currency symbol in the
give_format_currency() function.
I will look at it again later today.

Sent using CloudMagic [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=6.0.64&pv=8.1]
On Thu, Feb 25, 2016 at 3:37 p.m., Devin Walker notifications@github.com
wrote:
Issue found:

2-25-2016 3-37-04 pm
[https://cloud.githubusercontent.com/assets/1571635/13338351/af492472-dbd5-11e5-9588-819b96338320.png]
[https://cloud.githubusercontent.com/assets/1571635/13338351/af492472-dbd5-11e5-9588-819b96338320.png]


Reply to this email directly or view it on GitHub
[https://github.com//issues/485#issuecomment-189035830] .[https://github.com/notifications/beacon/AAIPG5dqQjQd16QedwwtSD7mUuRtfskCks5pn4e9gaJpZM4HgBMB.gif]

@DevinWalker
Copy link
Member

Don't worry I got it working

@DevinWalker
Copy link
Member

See 5ae9a39

@pryley
Copy link
Contributor Author

pryley commented Feb 26, 2016

👍🏼

Sent using CloudMagic [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=6.0.64&pv=8.1]
On Thu, Feb 25, 2016 at 4:05 p.m., Devin Walker notifications@github.com
wrote:
Don't worry I got it working


Reply to this email directly or view it on GitHub
[https://github.com//issues/485#issuecomment-189045368] .[https://github.com/notifications/beacon/AAIPGyS-ijd_zkhB-Ec5RxHlqfsgRE7Cks5pn44wgaJpZM4HgBMB.gif]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants