Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Audit & Resolution #736

Closed
ramiy opened this issue Jul 15, 2016 · 13 comments
Closed

RTL Audit & Resolution #736

ramiy opened this issue Jul 15, 2016 · 13 comments
Assignees
Milestone

Comments

@ramiy
Copy link
Contributor

ramiy commented Jul 15, 2016

See the attached screenshot:

give add ons page rtl issues

@ramiy
Copy link
Contributor Author

ramiy commented Jul 15, 2016

The plugin needs an RTL audit. Many pages are missing RTL view.

@ramiy
Copy link
Contributor Author

ramiy commented Jul 15, 2016

rtl

@ramiy
Copy link
Contributor Author

ramiy commented Jul 16, 2016

Front end issues:

front1

front2

@DevinWalker DevinWalker changed the title RTL issues on the addons page RTL Audit & Resolution Jul 18, 2016
@DevinWalker DevinWalker added Epic and removed Epic labels Jul 18, 2016
@DevinWalker DevinWalker added this to the 1.6 milestone Jul 18, 2016
@ramiy ramiy mentioned this issue Jul 24, 2016
Closed
@ramiy
Copy link
Contributor Author

ramiy commented Jul 24, 2016

addons-rtl

Fixed RTL addons page

DevinWalker pushed a commit that referenced this issue Jul 25, 2016
DevinWalker pushed a commit that referenced this issue Jul 25, 2016
@DevinWalker
Copy link
Member

DevinWalker commented Jul 25, 2016

There are a few lingering issues here after merging in #796

Still an issue:

3c564940-4b4c-11e6-8a34-b1f0807e2972

@ramiy
Copy link
Contributor Author

ramiy commented Jul 25, 2016

@DevinWalker yes I know.

I fixed the admin issues first, it's easier. Now I'm moving to the FrontEnd.

@DevinWalker
Copy link
Member

Thanks for the update @ramiy it's looking good - I can almost read RTL now 👀

@ramiy
Copy link
Contributor Author

ramiy commented Jul 26, 2016

@DevinWalker,

For now the RTL is working. Not 100% but I guess it fixes over 95% of the cases.

Currently, rtl.scss is updated manually. In the future we will need to do that automatically using a gulp taks.

@DevinWalker
Copy link
Member

Hey @ramiy I just reviewed #812 and notice a few items:

  1. Should the border and icon be moved to the right for all notices?
    rtl1
  2. This border appears to be missing:
    rtl2
  3. When clicking the donate button the loading icon should not move the button - rather it should appear to the right/left of it:
    rtl3
    rtl4

@ramiy
Copy link
Contributor Author

ramiy commented Jul 26, 2016

@DevinWalker Ok, I fixed the warnings and the total-amount border.

@ramiy
Copy link
Contributor Author

ramiy commented Jul 26, 2016

As for the gulp task, if I'm not mistaking, It will require us to update the SCSS/CSS depending on the library we will use. Each library has it's own ignore rules and other settings.

@DevinWalker
Copy link
Member

@ramiy do you have any examples in mind or links to articles about doing this? 👍

Fixed with merge here: #812

@ramiy
Copy link
Contributor Author

ramiy commented Jul 28, 2016

DevinWalker pushed a commit that referenced this issue Jul 29, 2016
Style touch ups for various RTL items #736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants