-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bye bye Qtip2 and hello Hint.css Tooltips #1596
Conversation
Syncing up Release/1.9
…athetos-release/1.9 # Conflicts: # assets/css/give-admin-rtl.css # assets/css/give-admin-rtl.min.css # assets/css/give-admin.css # assets/css/give-admin.min.css # assets/js/admin/admin-scripts.min.js # assets/js/frontend/give.all.min.js # assets/sourcemaps/give-admin.css.map # assets/sourcemaps/give.css.map # includes/forms/template.php # templates/give-rtl.css # templates/give-rtl.min.css # templates/give.css # templates/give.min.css
* release/1.8.6: Thou shalt not support PHP 5.2 Improved payment status language Reordered to fix travis error Attempting to fix broken PHPunit tests Fix: typo in currency section setting Fix: generate level class and id with price_id instead of fix #1592 Update README.md Update Documentation. Text update Removed duplicate returns array of objects Return “all” rather than empty to prevent conflicts with level ID 0 Remove space Prettier nonce failure notice #1571 Code reformatting Removed unused variables Removed unused code #1571 # Conflicts: # assets/js/admin/admin-scripts.min.js
* master: (36 commits) New POT file for 1.8.6 Gulp Additional adjustments to responsive handling #1544 Typo fix Basic fix for responsive dropdown #1544 Versions updated and readme added for 1.8.6 Removing during tests Still testing Remove codesniffer for now Updating composer.json to fix 7.1 error New .gitattributes file export ignore file - brought over from Woo New PHPCS ruleset - brought over from Woo Fix: stop firing additional ajax request while choosing form for exporting donors Fix: php notices which comes when requesting for form levels by ajax Update: run gulp concat_scripts Add: global js to toggle terms Remove: inline toggle term and conditions js Fix: improve code formatting Fix: php compatibility releated issue of code Update: should be an array Refacter: multi donation form payment test ... # Conflicts: # assets/css/give-admin-rtl.min.css # assets/css/give-admin.min.css # assets/js/admin/admin-scripts.min.js # assets/js/frontend/give.all.min.js # assets/sourcemaps/give-admin.css.map
@DevinWalker I reviewed this PR and find following issues: 1. The tooltip content max width is not set.beforeafter2 . The tooltip is not showing for the wrong amount.beforeafter3. The tooltip is not mobile friendly.beforeafter4. The tooltip is not working on the donation listing page.beforeafter5. The tooltip is not working on the donation detail page.beforeafter6. The tooltip is not working on the logs page.beforeafter7. The tooltip is not working on the reports page.beforeafter8. The tooltip is not working on the system info page.before#### afterNote To resolve point 3 we can look this example https://osvaldas.info/elegant-css-and-jquery-tooltip-responsive-mobile-friendly |
Requirements for Merging1. Tooltips are backwards compatible with the current qtip2 ones. - [ ]Perhaps this can be completed by detecting the current dom class/attributes with qtips and initializing hint.css rather. 2. Remove the usage of the word "fake" throughout the PR - [ ]I understand we're simply extending hint.css so it can be prefixed with simply "Give" |
@DevinWalker Both point fixed. But hint.css can face some problem with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevinWalker This PR is working fine for me
Description
Fixed conflict from: #1376
Resolves #619 and submitted specifically to release/1.9
Does the following:
There's room for improving this implementation of hint.css to give users more flexibility, but this PR is just about replacing qtips with hint.css out of the box. Additional features can come later.
I tested each individual tooltip in the Admin and front-end. If we merge this, these changes will have to be done in Add-ons as well.
Items check for compatibility
give_add_qtip()
in wp-adminScreenshots (jpeg or gifs if applicable):
Types of changes
Checklist: