Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - Issue #1692 #1693

Merged
merged 3 commits into from
May 16, 2017
Merged

Fixed - Issue #1692 #1693

merged 3 commits into from
May 16, 2017

Conversation

mehul0810
Copy link
Contributor

Description

This PR is for #1692

How Has This Been Tested?

This issue has been tested in 4 different use cases for reports generation in PDF:

  1. with both Categories and Tags disabled
  2. with Categories disabled and Tags enabled
  3. with Categories enabled and Tags disabled
  4. with both Categories and Tags enabled

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@DevinWalker DevinWalker merged commit c22bd50 into impress-org:master May 16, 2017
@DevinWalker
Copy link
Member

Thanks @mehul0810 - next time please submit the PR to the release branch the issue belongs to. In this case it would be release/1.8.8 rather than the master branch. 👍

mehul0810 added a commit to mehul0810/Give that referenced this pull request May 17, 2017
Merge pull request impress-org#1693 from mehul0810/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants