Allow multiple data-substep-order with the same value #825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #779, the ability to add the order of substeps using the
data-substep-order
has been added. The current implementation relies on the assumption that all the given numbers are unique: a sequence1, 2, 10, 100
is correctly handled, but another1, 1, 2, 2
is not. I find the latter very useful to show multiple elements of different DOM nodes in a single substep.Take for instance a slightly modified version of @codesections' original example from #779 (comment).
In contrast to the original example, the examples are shown in a single, last substep.
This PR adds the correct handling of multiple
data-substep-order
with the same value. I don't think it needs to be explicitly stated in the plugin's README – as I originally thought it would already be supported :)A real-world example that uses the proposed change can be found at multiple occasions in the slides of my PhD defense (source code).