fix: ensure connect event is fired only once #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connect() failed and it started reconnecting, it kept adding more and more listeners to pgClient connect event, and when it finally fired, all those listeners would also fire. So if it had to reconnect 5 times before succeeding, the connect event would have been fired 6 times.
veyh
force-pushed
the
fix-multiple-connect-events
branch
from
140761d
to
ab9a4b6
Compare
|
Thank you for contribution! |
|
Fix published in v1.5.2+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the library. I found a bug with the reconnects, and here's a fix.
Basically, when connect() failed and it started reconnecting, it kept adding more and more listeners to pgClient connect event, and when it finally fired, all those listeners would also fire. So if it had to reconnect 5 times before succeeding, the connect event would have been fired 6 times.
Try the test without the fix, it will fail.