Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#64) Support tasks retry & propagate raised exception #65

Merged
merged 1 commit into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. (#64) Support tasks retry & propagate raised exception

    For documentation, see:
    1. Docstring of `task.task`
    2. Tests in `tests.test_task` e.g. `test_retry_as_per_task_definition`
    3. Sample usages in `tests.apps.simple_app` e.g. `append_to_file`
    
    Changelist:
    
    * Formalize serialization and deserialization
    * Serialize & deserialize exceptions correctly
    * Encapsulate retry & retry_on in a new dict 'options'
    * Implement serde for AsyncResult
    * Ensure generated file deleted after test
    * Add jsonpickle to toml file
    * Exclude `if TYPE_CHECKING:` from coverage
    * Add test for singleton
    * Add logging for worker
    * Wrap all constants inside `Config` class
    * Handle case when `options.retry.on` is empty
    
    Signed-off-by: Imran Ariffin <ariffin.imran@gmail.com>
    
    Requested changes:
    
    * Rename constants.py to config.py
    * Split file into config.py & constants.py
    * Avoid retrying forever
    * Move logic from `AsyncResult.from_publisher` to
      `Task._get_result`. This way `AsyncResult` can be
      just a pure class with no side-effect
    
    Fixups:
    
    * Fix docker-compose cmd not found on GithubAction
    imranariffin committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ed6c94f View commit details
    Browse the repository at this point in the history